Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example for max-pos-args #9796

Closed
wants to merge 1 commit into from
Closed

Fix example for max-pos-args #9796

wants to merge 1 commit into from

Conversation

emilte
Copy link
Contributor

@emilte emilte commented Feb 2, 2024

Summary

Test Plan

charliermarsh
charliermarsh approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Feb 2, 2024
@emilte
Copy link
Contributor Author

emilte commented Feb 2, 2024 •
edited
Loading

Whoops, this PR was unintentional. I was testing the browser interface on github. You can close this in favor of this one #9797

@charliermarsh
Copy link
Member

No prob, will do.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error) 

ruff failed
  Cause: Selection of unstable rules without the `--preview` flag is not allowed. Enable preview or remove selection of:
	- FURB113
	- FURB131
	- FURB132

Linter (preview)

✅ ecosystem check detected no linter changes.

@emilte emilte deleted the use-correct-key-for-max-pos-args branch February 2, 2024 20:33
@emilte emilte restored the use-correct-key-for-max-pos-args branch February 2, 2024 20:33
@emilte emilte deleted the use-correct-key-for-max-pos-args branch February 2, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilte @charliermarsh