Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv pip install "apache-airflow[all]" fails to install the required extras #1342

Closed
notatallshaw opened this issue Feb 15, 2024 · 2 comments · Fixed by #1435
Closed

uv pip install "apache-airflow[all]" fails to install the required extras #1342

notatallshaw opened this issue Feb 15, 2024 · 2 comments · Fixed by #1435
Assignees
Labels
bug Something isn't working

Comments

@notatallshaw
Copy link
Contributor

Hi all, just found out about this project, I've done a lot of work to test and improve real world resolution performance for Pip and done a lot of testing against Rip.

I'm very excited to also test uv, especially with it's very interesting resolution options!

My first most common test to check any new resolution library is to try apache-airflow[all], when I run (on Linux CPython 3.10):

pip install "apache-airflow[all]"

I get 428 packages installed, but when I run:

uv pip install "apache-airflow[all]"

I get 139 packages installed, is uv currently ignoring extras?

@charliermarsh
Copy link
Member

It shouldn't be, no! Extras are definitely supported and we have a bunch of test coverage for it. Lemme look into this.

@zanieb
Copy link
Member

zanieb commented Feb 15, 2024

Thanks for the report! It looks like you found a hole in our test scenarios.

I've reproduced this in #1352

We don't support recursive extras at this time, but will asap!

@zanieb zanieb added the bug Something isn't working label Feb 15, 2024
@charliermarsh charliermarsh self-assigned this Feb 15, 2024
charliermarsh added a commit that referenced this issue Feb 16, 2024
## Summary

We had a guard in the resolve to avoid "self-dependencies" (as in
`gps3==0.33.3`), but this guard was _unintentionally_ filtering out
recursive extras.

Closes #1342.

## Test Plan

Taken from #1352.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants