Consider to hide --index-url and --extra-index-url if --emit-index-url flag is not presented
#1834
Comments
|
We hide these by default in the body, right? So would this mainly be to remove them from the comment header? |
Yes, exactly, only in the header comment, the body of the requirements is looking good |
charliermarsh
pushed a commit
that referenced
this issue
Feb 23, 2024
## Summary Hey guys! The motivation described in #1834 ## Test Plan Changed snapshot of the existing tests. `--index-url` and `--extra-index-url` occur pretty often, so no extra testing is required, imo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey guys! As the title said, I wonder if the
uvcould hide--index-urland--extra-index-urlif the--emit-index-urlflag is not presented. Otherwise, if you have a private package index, this data could be accidentally committed to the repository.pip-toolshides the index and extra index both from the command in the comment and of course does not include them in the body of the compiled files.I've created a small PR to do this, but if this is "by design", than I'll just close it :)
The text was updated successfully, but these errors were encountered: