Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated pip reference in "Strictness and spec enforcement" docs #8412

Closed
edmorley opened this issue Oct 21, 2024 · 3 comments · Fixed by #8822
Closed

Outdated pip reference in "Strictness and spec enforcement" docs #8412

edmorley opened this issue Oct 21, 2024 · 3 comments · Fixed by #8822
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@edmorley
Copy link
Contributor

edmorley commented Oct 21, 2024

On https://docs.astral.sh/uv/pip/compatibility/#strictness-and-spec-enforcement it says:

uv tends to be stricter than pip, and will often reject packages that pip would install. For example, uv omits packages with invalid version specifiers in its metadata, which pip similarly plans to exclude in a future release.

As of pip 24.1, pip now rejects those versions too - so it's no longer a "future release".

I was going to open a PR to remove that last sentence, however, it seems that it would be useful if this section of the docs still had an example - so I thought you might want to add another in its place (and I don't know of any)?

@zanieb
Copy link
Member

zanieb commented Oct 21, 2024

Thanks! I guess we could say "For example, uv omits packages with invalid version specifiers in its metadata, which pip similarly excludes in recent versions" and punt another example to the future?

@konstin may have another example.

@zanieb zanieb added the documentation Improvements or additions to documentation label Oct 21, 2024
@konstin
Copy link
Member

konstin commented Oct 22, 2024

Pre-PEP 517 backwards is stronger in pip, we could use that as new example.

@charliermarsh charliermarsh self-assigned this Nov 5, 2024
@charliermarsh
Copy link
Member

I found something to replace this with.

charliermarsh added a commit that referenced this issue Nov 5, 2024
## Summary

pip now enforces this too! Let's use a different example.

Closes #8412.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants