Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid showing negations of single ranges in error messages #980

Closed
zanieb opened this issue Jan 18, 2024 · 0 comments · Fixed by #981
Closed

Avoid showing negations of single ranges in error messages #980

zanieb opened this issue Jan 18, 2024 · 0 comments · Fixed by #981
Labels
error messages Messaging when something goes wrong

Comments

@zanieb
Copy link
Member

zanieb commented Jan 18, 2024

e.g. in https://github.com/astral-sh/puffin/blob/6cad0f609caba5354f528cc3dba813f0c26a0e27/crates/puffin-cli/tests/pip_install_scenarios.rs#L688

we have !( a>=3.0.0 ) but since it's just a single item in the negation we should just perform the complement.
@zanieb zanieb added the error messages Messaging when something goes wrong label Jan 18, 2024
zanieb added a commit that referenced this issue Jan 18, 2024
@zanieb
Avoid showing negations of single ranges in error messages
162eb7c 
Closes #980
@zanieb zanieb mentioned this issue Jan 18, 2024
Merged
zanieb added a commit that referenced this issue Jan 19, 2024
@zanieb
Avoid showing negations of single ranges in error messages
da60e6b 
Closes #980

# Conflicts:
#	crates/puffin/tests/pip_install_scenarios.rs
zanieb added a commit that referenced this issue Jan 19, 2024
@zanieb
Avoid showing negations of ranges in error messages (#981)
ae7a2cd 
Closes #980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
error messages Messaging when something goes wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid showing negations of ranges in error messages astral-sh/uv
1 participant
@zanieb