Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that /bin/ls can sometimes be plain text file. For
example, in Rocky Linux 9:
However,
/bin/sh
is an ELF binary:In a related issue (#1433), @zanieb fixed #1395 where, on NixOS,
/bin/ls
doesn't exist but/bin/sh
does. However, the fix attempts/bin/ls
first and only tries/bin/sh
if/bin/ls
doesn't exist. If/bin/ls
exists but isn't a valid ELF file, then the entire enterprisegives up and
uv
fails to detect the version oflibc
that isinstalled.
Instead of tweaking the logic to keep trying
/bin/ls
and then/bin/sh
after even if parsing/bin/ls
fails, we just switch over toreading
/bin/sh
only. It seems like a more fundamental thing to sniffand likely less error prone.
We can adjust this heuristic as needed if it provdes to be problematic.
I tested this fix manually on Rocky Linux 9 via Docker:
Fixes #1486, Ref #1433