-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the system trust store for HTTPS requests #1512
Conversation
Using the `rustls-tls-native-roots` feature seanmonstar/reqwest#1554
The major downsides are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay to me. In particular, it seems like this is the recommended approach from rustls.
FYI, Pip is moving to this model via truststore: https://pip.pypa.io/en/stable/topics/https-certificates/ My experience is it is massively helpful in large organization environments. |
Corporate network with ssl inspection firewall, custom ca on every site. Root certificate is trusted by windows, and environment variables REQUESTS_CA_BUNDLE and SSL_CERT_FILE are setup. Python requests work fine. Pip install as well. uv fails with error below.
|
Hi @carlosjourdan would you mind opening a new issue? |
Just did |
Closes #1474
Using the
rustls-tls-native-roots
featureAdditional context:
Prior discussion at #609