Build source distributions in the cache directory instead of the global temporary directory #1628
Conversation
…al temporary directory
|
There's another case where we use the cache directory root to create temporary directories so this seems okay. I don't know if we want a dedicated bucket for these eventually? |
| @@ -283,7 +283,7 @@ impl SourceBuild { | |||
| setup_py: SetupPyStrategy, | |||
| build_kind: BuildKind, | |||
| ) -> Result<SourceBuild, Error> { | |||
| let temp_dir = tempdir()?; | |||
| let temp_dir = tempdir_in(build_context.cache().root())?; | |||
There was a problem hiding this comment.
Should this maybe actually be wheel_dir, i.e., the directory we pass to build? Unfortunately that's not an argument to this. In practice wheel_dir is also always inside the cache so it's probably fine, but perhaps worth documenting.
There was a problem hiding this comment.
Maybe, we can consider a slightly larger change next?
What's the meaning of "wheel_dir" anyway? Where we're going to place the built wheel?
There was a problem hiding this comment.
Yeah I'm cool with this change.
Yeah the wheel_dir is the directory into which we build the wheel. So if it's foo, the wheel gets built and saved at foo/Jinja2.whl or whatever (IIRC).
Addresses report in #1444 where a temporary directory is created outside of the cache directory or current virtual environment.
There is one additional usage of bare
tempdiroutside of tests we may want to change:uv/crates/install-wheel-rs/src/wheel.rs
Line 567 in 2586f65