Control pip timeout duration via environment variable #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Feb 19, 2024
zanieb
reviewed
Feb 19, 2024
zanieb
reviewed
Feb 20, 2024
| match value.parse::<u64>() { | ||
| Ok(parsed) => parsed, | ||
| Err(_) => { | ||
| eprintln!("Warning: UV_REQUEST_TIMEOUT is an invalid value. Using default value."); |
There was a problem hiding this comment.
We have a warn_user_once! macro that we should use instead here.
There was a problem hiding this comment.
Would it make sense to use .map_err instead of a match here?
There was a problem hiding this comment.
I'd also probably be a little clearer here, maybe:
Ignoring invalid value for UV_REQUEST_TIMEOUT. Expected integer number of seconds, got "{value}".
zanieb
reviewed
Feb 20, 2024
| } | ||
| Err(_) => default_timeout, | ||
| }; | ||
| debug!("Pip request timeout is {}.", timeout); |
There was a problem hiding this comment.
We should probably not say "Pip" this is our general registry client
Suggested change
| debug!("Pip request timeout is {}.", timeout); | |
| debug!("Using registry request timeout of {}s", timeout); |
|
@zanieb |
zanieb
added a commit
that referenced
this pull request
Feb 21, 2024
…OUT` (#1780) Follow-up to #1694 matching Cargo's environment variable names https://doc.rust-lang.org/nightly/cargo/reference/config.html#httptimeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the environment variable
UV_REQUEST_TIMEOUTto allow control over pip timeouts.Closes #1549
Test Plan
I built uv in the repository top Dockerfile, set the timeout to 3 seconds, and ran
uv pip install torch.I measured the execution time with the time command and confirmed that the process finished at a value close to the timeout we set.