Add support for absolute paths on Windows #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/abs-path
branch
5 times, most recently
from
393ab52
to
a995adf
Compare
charliermarsh
force-pushed
the
charlie/abs-path
branch
from
a995adf
to
2c07cd5
Compare
charliermarsh
force-pushed
the
charlie/abs-path
branch
from
2c07cd5
to
6a37c03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The main change is that we need to have an explicit list of protocols we do support (like
https), so that when we see a Windows absolute path (C:\...), we don't treat theCas a protocol itself.Closes #1539.