Add support for pip-compile's --unsafe-package flag
#1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
enhancement
|
I'm torn on the name |
|
Yeah :-/ It's unfortunate that pip-compile puts those words in the file. I do think it'd be nice to have an |
charliermarsh
force-pushed
the
charlie/unsafe-package
branch
from
948ffbe
to
5a8b22f
Compare
| writeln!( | ||
| writer, | ||
| "{}", | ||
| "# The following packages were included while generating the resolution:".green() |
There was a problem hiding this comment.
Thank you for implementing the feature!
nit: I was confused by "include" here, maybe The following packages were omitted from the result: (although maybe omit vs no-emit confuses folks too, so maybe just "excluded")
There was a problem hiding this comment.
Good idea -- changed in #1935.
charliermarsh
added a commit
that referenced
this pull request
Feb 23, 2024
Good feedback from: #1889 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In uv, we're going to use
--no-emit-packagefor this, to convey that the package will be included in the resolution but not in the output file. It also mirrors flags like--emit-index-url.We're also including an
--unsafe-packagealias.Closes #1415.