Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for deprecated python_implementation marker #1933

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Like platform.python_implementation, we should support the python_implementation "alias" for platform_python_implementation.

Closes #1906.

Test Plan

❯ cargo run pip install "pynacl==1.4.0"
    Finished dev [unoptimized + debuginfo] target(s) in 7.02s
     Running `target/debug/uv pip install pynacl==1.4.0`
Resolved 4 packages in 9ms
   Built pynacl==1.4.0                                                                                                                                                                                                                        Downloaded 1 package in 31.51s
Installed 4 packages in 3ms
 + cffi==1.16.0
 + pycparser==2.21
 + pynacl==1.4.0
 + six==1.16.0

@charliermarsh charliermarsh added bug Something isn't working compatibility Compatibility with a specification or another tool labels Feb 23, 2024
@charliermarsh charliermarsh merged commit 5056534 into main Feb 23, 2024
7 checks passed
@charliermarsh charliermarsh deleted the charlie/impl branch February 23, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility Compatibility with a specification or another tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install pynacl==1.4.0
1 participant