Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast lint CI job: Rustfmt, Prettier, Ruff #2406

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

konstin
Copy link
Member

@konstin konstin commented Mar 13, 2024

Add a single job for for fast lint tools. Rustfmt for rust, ruff for python formatting and linting, prettier avoids inconsistent formatter changes between pycharm and vscode.

@konstin konstin added the internal A refactor or improvement that is not user-facing label Mar 13, 2024
@konstin konstin requested review from charliermarsh and zanieb March 13, 2024 10:35
@konstin
Copy link
Member Author

konstin commented Mar 13, 2024

Should we do a single task that does all the fast linters: rustfmt, prettier (yml), ruff format and ruff check? The github UI becomews unwieldy with too many jobs:

grafik

@zanieb
Copy link
Member

zanieb commented Mar 13, 2024

I'd be down to have all the formatting run in a single job, yeah

@konstin konstin removed the request for review from charliermarsh March 18, 2024 09:38
@konstin konstin force-pushed the konsti/format-yaml-files branch from dc585a1 to d81682f Compare March 18, 2024 09:39
@konstin konstin changed the title Use prettier to enforce yaml formatting Fast lint CI job: Rustfmt, Prettier, Ruff Mar 18, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) March 20, 2024 00:08
@charliermarsh charliermarsh merged commit 79fbac7 into main Mar 20, 2024
31 checks passed
@charliermarsh charliermarsh deleted the konsti/format-yaml-files branch March 20, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants