-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix priority of platform tags for manylinux #2483
Conversation
b904121
to
46a9992
Compare
I fixed the ordering of the abi tags, but I'm not sure where it's documented that Looks correct per https://github.com/pypa/packaging/blob/fd4f11139d1c884a637be8aa26bb60a31fbc9411/packaging/tags.py#L434-L444 |
I think it might be the other way around, I think higher priority tags come first in that code, so |
You can test by comparing to: from packaging import tags
for tag in tags.sys_tags(): print(tag) |
d411511
to
b8a8624
Compare
Apologies for all the back and forth apparently this needed a more rigorous look :) I've addressed the last round of comments. I might look into a better way to test we match Python's behavior. |
It looks like our ordering of ABI tags is wrong, i.e. Python does
but we do
This is a different part of the code though, I'll address in a second pull request. |
b8a8624
to
1cd86fd
Compare
Oh interesting… they might be mutually exclusive such that it hasn’t mattered? Hard to reason about from my phone :D Thank you for digging into this! |
ec7d8cc
to
b325acd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m comfortable signing off on this if you want to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks right to me too.
# Conflicts: # crates/platform-tags/src/tags.rs # Conflicts: # crates/platform-tags/src/tags.rs # Conflicts: # crates/platform-tags/src/tags.rs
b325acd
to
313dd0c
Compare
Closes #2477
See also: