Allow direct file path requirements to include fragments #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thank you. Looks like there's one test failure on Windows. |
eth3lbert
force-pushed
the
path-fragment
branch
from
4105519 to
b9b75cf
Compare
eth3lbert
force-pushed
the
path-fragment
branch
2 times, most recently
from
9bded81 to
f6e30d7
Compare
|
Will review and merge tomorrow, thanks! |
charliermarsh
force-pushed
the
path-fragment
branch
from
f6e30d7 to
ed7ff98
Compare
charliermarsh
approved these changes
Mar 18, 2024
charliermarsh
changed the title
charliermarsh
force-pushed
the
path-fragment
branch
from
ed7ff98 to
0f10760
Compare
charliermarsh
force-pushed
the
path-fragment
branch
from
0f10760 to
131b145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles the fragment part of the URL path.
It achieves this by splitting the fragment from the path before normalization and parsing. It then sets the fragment back after the URL has been parsed.
Resolve #2501