Search in both purelib and platlib for site-packages population
#2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert crates Revert "Revert crates" This reverts commit 1cd90c6.
charliermarsh
force-pushed
the
charlie/site-packages
branch
from
873f4f7
to
ea1fbef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In reality, there's no such thing as the
site-packagesdirectory for a given virtualenv. Rather, Python defines bothpurelibandplatlib, where the former is for pure-Python packages and the latter is for packages that contain native code. These are almost always set to the same thing... but they don't have to be, and in fact of Fedora they are not.This PR changes the
site_packagesmethod to return an iterator of directories.Note that the system tests introduced in #2535, which failed on the PR itself, now pass.
Closes #2527.