Add support for parsing unnamed URL requirements #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/bare-i
branch
8 times, most recently
from
47dd6cd
to
ae55727
Compare
charliermarsh
commented
Mar 20, 2024
| @@ -1254,6 +1249,27 @@ mod test { | |||
| insta::assert_debug_snapshot!(snapshot, actual); | |||
| } | |||
|
|
|||
| #[cfg(unix)] | |||
| #[test_case(Path::new("bare-url.txt"))] | |||
There was a problem hiding this comment.
I really tried, but there are so many weirdnesses in the Windows version because it's a file URL, or something. I gave up with the filters.
charliermarsh
force-pushed
the
charlie/bare-i
branch
4 times, most recently
from
ea57da0
to
48ea955
Compare
zanieb
reviewed
Mar 20, 2024
zanieb
reviewed
Mar 20, 2024
zanieb
approved these changes
Mar 20, 2024
charliermarsh
force-pushed
the
charlie/bare-i
branch
from
48ea955
to
d9b10f2
Compare
charliermarsh
force-pushed
the
charlie/bare-i
branch
from
d9b10f2
to
2b18d31
Compare
charliermarsh
force-pushed
the
charlie/bare-i
branch
2 times, most recently
from
fb6d149
to
1dd4c68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
First piece of #313. In order to support unnamed requirements, we need to be able to parse them in
requirements-txt, which in turn means that we need to introduce a new type that's distinct frompep508::Requirement, given that these aren't PEP 508-compatible requirements.Part of: #313.