Allow package lookups across multiple indexes via explicit opt-in #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/multi-index
branch
3 times, most recently
from
8a436e4
to
ba0bfd6
Compare
charliermarsh
added
enhancement
charliermarsh
force-pushed
the
charlie/multi-index
branch
3 times, most recently
from
8a8adef
to
29c63a4
Compare
|
It'd be nice to also have an env variable option like: |
zanieb
reviewed
Apr 3, 2024
charliermarsh
force-pushed
the
charlie/multi-index
branch
from
29c63a4
to
1c6c606
Compare
This was referenced Apr 3, 2024
BurntSushi
reviewed
Apr 8, 2024
| /// the first index before moving on to the next. Further, if a version is found to be | ||
| /// incompatible in the first index, we do not reconsider that version in subsequent indexes, | ||
| /// even if the secondary index might contain compatible versions (e.g., variants of the same | ||
| /// versions with different ABI tags or Python version constraints). |
There was a problem hiding this comment.
It might be worth ~one sentence mentioning that this risks dependency confusion attacks so that the "unsafe" in the name is justified here. (I know the PEP link gives the full context, but I think a one sentence call out here is important.)
(I'm assuming this is user facing docs. If not, the PEP link is enough IMO.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This partially revives #2135 (with some modifications) to enable users to opt-in to looking for packages across multiple indexes.
The behavior is such that, in version selection, we take any compatible version from a "higher-priority" index over the compatible versions of a "lower-priority" index, even if that means we might accept an "older" version.
Closes #2775.