Deduplicate symbolic links between purelib and platlib
#3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/suse
branch
10 times, most recently
from
140518f
to
c399683
Compare
charliermarsh
changed the title
purelib and platlib
charliermarsh
added
bug
|
I can confirm, that this does fix the specific issue I was having. Thanks! |
charliermarsh
force-pushed
the
charlie/suse
branch
from
c399683
to
e3086a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds system install tests to verify the behavior described in #2798. It turns out this behavior also affects Fedora and Amazon Linux, we just didn't have the right conditions enabled (specifically, you need to create the virtualenv with
python -m venvto get these symlinks), so the test suite was expanded to capture that.The issue itself is also fixed by way of deduplicating the
site-packagesentries.Closes: #2798