Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serde dependency of uv-resolver is not optional #3316

Closed
wants to merge 2 commits into from
Closed

serde dependency of uv-resolver is not optional #3316

wants to merge 2 commits into from

Conversation

ibraheemdev
Copy link
Member

Summary

#3314 makes uv-resolver unconditionally depend on serde, so the dependency should not be optional. This was breaking #3281.

@ibraheemdev ibraheemdev added the internal A refactor or improvement that is not user-facing label Apr 29, 2024
@ibraheemdev
Copy link
Member Author

ibraheemdev commented Apr 29, 2024 •
edited
Loading

Realized the new types don't actually unconditionally required serde, so they should only implement Serialize/Deserialize if serde is enabled.

@ibraheemdev ibraheemdev deleted the uv-resolver-serde branch April 29, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibraheemdev @zanieb