List and uninstall legacy editables #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this is looking good. I'll try and merge it tonight. |
charliermarsh
added
enhancement
|
|
||
| // https://github.com/pypa/pip/blob/41587f5e0017bcd849f42b314dc8a34a7db75621/src/pip/_internal/req/req_uninstall.py#L634 | ||
| for line in content.lines() { | ||
| if !removed && line.trim() == target_line { |
There was a problem hiding this comment.
I think we need to do a case-insensitive compare here on Windows, maybe?
charliermarsh
approved these changes
May 7, 2024
hauntsaninja
added a commit
to hauntsaninja/uv
that referenced
this pull request
May 8, 2024
Thanks for the suggestion from astral-sh#3415 (comment) Also it looks like you improved `egg-link` parsing in astral-sh@e23c91f so copying the changes over to the other parse site
hauntsaninja
added a commit
to hauntsaninja/uv
that referenced
this pull request
May 8, 2024
Thanks for the suggestion from astral-sh#3415 (comment) Also it looks like you improved `egg-link` parsing in astral-sh@e23c91f so copying the changes over to the other parse site
konstin
pushed a commit
that referenced
this pull request
May 8, 2024
Thanks for the suggestion from #3415 (comment) Also it looks like you improved `egg-link` parsing in e23c91f so copying the changes over to the other parse site (happy to move this to a helper too, if so lmk where to put it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #3396