ci: build musllinux_1_1 wheels #3523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Making this draft because I forgot the cross-compiled musl wheels. I'll wait to see if it works first) |
This is needed to include uv in manylinux, which has both the musllinux_1_1 and musllinux_1_2 images. Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
commented
May 11, 2024
charliermarsh
approved these changes
May 11, 2024
|
Awesome, thank you! |
charliermarsh
added
the
releases
Merged
charliermarsh
pushed a commit
that referenced
this pull request
May 15, 2024
## Summary Working on followup to #3523. I expect some changes will be required to match the glibc versions above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to include uv in manylinux, which has both the musllinux_1_1 and musllinux_1_2 images.
Summary
We are looking into including uv in the
pypa/manylinuxdocker images, so that cibuildwheel will be able to use it. But to do so, we need all actively supported images to be able to take it, including musllinux_1_1.Test Plan
The test was updated to make sure Alpine 3.12, which musllinux was based on, can run uv.
The binary build does need to be triggered on this PR to make sure it works. Ah,
uv/.github/workflows/build-binaries.yml
Lines 15 to 20 in 5b60401
Will need a followup to fill out the other platforms
pypa/manylinuxsupports for musllinux.