Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make isolated a global argument #3558

Merged
merged 1 commit into from
May 13, 2024
Merged

Make isolated a global argument #3558

merged 1 commit into from
May 13, 2024

Conversation

charliermarsh
Copy link
Member

Closes #3557.

@charliermarsh charliermarsh requested a review from zanieb May 13, 2024 17:45
charliermarsh
charliermarsh commented May 13, 2024
View reviewed changes
crates/uv/src/cli.rs

/// Avoid discovering a `pyproject.toml` or `uv.toml` file in the current directory or any
/// parent directories.
#[arg(global = true, long, hide = true)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We needed global = true.

@charliermarsh charliermarsh added bug Something isn't working cli Related to the command line interface labels May 13, 2024
@charliermarsh charliermarsh marked this pull request as ready for review May 13, 2024 17:45
zanieb
zanieb approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@charliermarsh charliermarsh enabled auto-merge (squash) May 13, 2024 17:47
@charliermarsh charliermarsh merged commit 7ed14fa into main May 13, 2024
44 checks passed
@charliermarsh charliermarsh deleted the charlie/iso branch May 13, 2024 17:51
@bluss
Copy link
Contributor

bluss commented May 13, 2024

the global options open the secret door where uv tells you about all you can really do. Don't know any other way to get it to spill the beans.

uv --preview
error: 'uv' requires a subcommand but one was not provided
  [subcommands: pip, venv, virtualenv, v, cache, self, clean, run, sync, lock,
version, generate-shell-completion, --generate-shell-completion, help]

@charliermarsh
Copy link
Member Author

Hahaha the hidden subcommands?

@bluss
Copy link
Contributor

bluss commented May 13, 2024

Yep 🙂 I guess, the shell completion is pretty open about them too though. Not --generate-shell-completion with dashes, that one is secret and v too.

@zanieb
Copy link
Member

zanieb commented May 13, 2024

Funny that seems like a Clap bug.

They're not too secret though :) just not ready for primetime.

@BrewTestBot BrewTestBot mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cli Related to the command line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Global CLI flags cannot be passed to commands
3 participants
@charliermarsh @bluss @zanieb