Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a cross-platform representation for relative paths in pip compile #3804

Merged
merged 5 commits into from
May 24, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented May 23, 2024

Summary

I haven't tested on Windows yet, but the idea here is that we should use a portable representation when printing paths.

I decided to limit the scope here to paths that we write to output files.

Closes #3800.

@charliermarsh charliermarsh added bug Something isn't working windows Specific to the Windows platform labels May 23, 2024
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool if it works!

@charliermarsh
Copy link
Member Author

Famous last words.

Copy link

codspeed-hq bot commented May 23, 2024

CodSpeed Performance Report

Merging #3804 will not alter performance

Comparing charlie/rel (0183c34) with main (dd27f2f)

Summary

✅ 13 untouched benchmarks

@charliermarsh
Copy link
Member Author

Alright, this isn't quite what we want. But I think I can use this crate to solve this specific problem.

@charliermarsh
Copy link
Member Author

Specifically, I think I can use this when we .join.

@charliermarsh
Copy link
Member Author

Ok, this definitely is not doing what I want.

@charliermarsh
Copy link
Member Author

Okay, this actually does do what we want.

@charliermarsh charliermarsh force-pushed the charlie/rel branch 10 times, most recently from c1d56f2 to 68601df Compare May 24, 2024 02:39
@charliermarsh charliermarsh changed the title Use a cross-platform representation for relative paths Use a cross-platform representation for relative paths in pip compile May 24, 2024
@charliermarsh charliermarsh merged commit 8d566e5 into main May 24, 2024
45 checks passed
@charliermarsh charliermarsh deleted the charlie/rel branch May 24, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows Specific to the Windows platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv compile now shows annotations for -c and -r paths that causes issues cross platform
2 participants