Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include package names for Git and HTTPS dependencies #3821

Merged
merged 1 commit into from
May 24, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented May 24, 2024

Summary

Related to #3818. We should always include the package name if we know it's not a file path, even if it starts with an environment variable.

Closes #3821, although there's another bug to fix there for local dependencies that I need to PR separately.

@charliermarsh charliermarsh enabled auto-merge (squash) May 24, 2024 13:49
@charliermarsh charliermarsh added the bug Something isn't working label May 24, 2024
@charliermarsh charliermarsh merged commit 999d072 into main May 24, 2024
45 checks passed
@charliermarsh charliermarsh deleted the charlie/unnamed branch May 24, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant