Allow normalization to completely eliminate markers #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Jun 12, 2024
| match tree { | ||
| MarkerTree::And(trees) | MarkerTree::Or(trees) => { |
There was a problem hiding this comment.
I split these into separate branches. There's a little bit of duplication, but it makes things easier with ownership (and the branches now have more deviations than before between the two cases).
charliermarsh
force-pushed
the
charlie/norm
branch
from
1b62c74
to
22b3c19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
normalizenow takes an owned value and returnsOption<MarkerTree>, such that if any sub-expression evaluates totrue, we can normalize out the entire marker.Closes #4267.