-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use consistent canonicalization for URLs #5980
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/new-relative-wheel
branch
2 times, most recently
from
August 9, 2024 23:30
30ff58c
to
95f2fc8
Compare
Ok the problem here is that the project directory gets canonicalized during workspace discovery... |
charliermarsh
force-pushed
the
charlie/new-relative-wheel
branch
3 times, most recently
from
August 10, 2024 00:41
3b2a516
to
4e70bda
Compare
charliermarsh
force-pushed
the
charlie/new-relative-wheel
branch
4 times, most recently
from
August 10, 2024 01:02
9b86c9a
to
d52af98
Compare
charliermarsh
force-pushed
the
charlie/new-relative-wheel
branch
from
August 10, 2024 01:11
d52af98
to
20e165b
Compare
This reverts commit 20e165b.
charliermarsh
force-pushed
the
charlie/new-relative-wheel
branch
from
August 10, 2024 01:23
f8dd83e
to
720d729
Compare
charliermarsh
added
bug
Something isn't working
and removed
testing
Internal testing of behavior
labels
Aug 10, 2024
charliermarsh
changed the title
Re-enable relative path test on Windows
Use consistent canonicalization for URLs
Aug 10, 2024
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Aug 15, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.2.35` -> `0.2.36` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.2.36`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0236) [Compare Source](astral-sh/uv@0.2.35...0.2.36) ##### Bug fixes - Use consistent canonicalization for URLs ([#​5980](astral-sh/uv#5980)) - Improve warning message when parsing `pyproject.toml` fails ([#​6009](astral-sh/uv#6009)) - Improve handling of overlapping markers in universal resolver ([#​5887](astral-sh/uv#5887)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the URL gets out-of-sync with the install path, since the install path is canonicalized. This leads to a subtle error on Windows (in CI) in which we don't preserve caching across resolution and installation.