Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent canonicalization for URLs #5980

Merged
merged 4 commits into from
Aug 10, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Aug 9, 2024

Right now, the URL gets out-of-sync with the install path, since the install path is canonicalized. This leads to a subtle error on Windows (in CI) in which we don't preserve caching across resolution and installation.

@charliermarsh charliermarsh added the testing Internal testing of behavior label Aug 9, 2024
@charliermarsh charliermarsh force-pushed the charlie/new-relative-wheel branch 2 times, most recently from 30ff58c to 95f2fc8 Compare August 9, 2024 23:30
@charliermarsh
Copy link
Member Author

Ok the problem here is that the project directory gets canonicalized during workspace discovery...

@charliermarsh charliermarsh force-pushed the charlie/new-relative-wheel branch 3 times, most recently from 3b2a516 to 4e70bda Compare August 10, 2024 00:41
@charliermarsh charliermarsh force-pushed the charlie/new-relative-wheel branch 4 times, most recently from 9b86c9a to d52af98 Compare August 10, 2024 01:02
This reverts commit 20e165b.
@charliermarsh charliermarsh marked this pull request as ready for review August 10, 2024 01:42
@charliermarsh charliermarsh added bug Something isn't working and removed testing Internal testing of behavior labels Aug 10, 2024
@charliermarsh charliermarsh changed the title Re-enable relative path test on Windows Use consistent canonicalization for URLs Aug 10, 2024
@charliermarsh charliermarsh merged commit 19ac9af into main Aug 10, 2024
57 checks passed
@charliermarsh charliermarsh deleted the charlie/new-relative-wheel branch August 10, 2024 01:43
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 15, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.2.35` -> `0.2.36` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.2.36`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0236)

[Compare Source](astral-sh/uv@0.2.35...0.2.36)

##### Bug fixes

-   Use consistent canonicalization for URLs ([#&#8203;5980](astral-sh/uv#5980))
-   Improve warning message when parsing `pyproject.toml` fails ([#&#8203;6009](astral-sh/uv#6009))
-   Improve handling of overlapping markers in universal resolver ([#&#8203;5887](astral-sh/uv#5887))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant