Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve simple no version messages using complement of range #979

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Improve simple no version messages using complement of range #979

merged 2 commits into from
Jan 19, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jan 18, 2024 •
edited
Loading

Improves some of the "no versions of are available" messages by showing the complement or inversion of the package.

Does not address cases like

Because there are no versions of crow that satisfy any of:
    crow>1.0.0,<2.0.0a5
    crow>2.0.0a7,<2.0.0b1
    crow>2.0.0b1,<2.0.0b5
...

which are a bit more complicated; I'll focus on those cases in a follow-up.

@zanieb zanieb changed the title zb/no versions Improve simple no version messages using complement of range Jan 18, 2024
@zanieb zanieb force-pushed the zb/no-versions branch 2 times, most recently from e954660 to 87dde4a Compare January 18, 2024 23:51
@zanieb zanieb added the error messages Messaging when something goes wrong label Jan 19, 2024
charliermarsh
charliermarsh approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think this is generally clearer.

Base automatically changed from zb/names to main January 19, 2024 16:01
@zanieb
Improve simple no version messages using complement of range
642b74b 
# Conflicts:
#	crates/puffin/tests/pip_install_scenarios.rs
@zanieb
Remove extra verbiage when only a single version is available
65a21a1 
# Conflicts:
#	crates/puffin/tests/pip_install_scenarios.rs
@zanieb zanieb enabled auto-merge (squash) January 19, 2024 16:46
@zanieb zanieb merged commit 02ed195 into main Jan 19, 2024
3 checks passed
@zanieb zanieb deleted the zb/no-versions branch January 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
error messages Messaging when something goes wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanieb @charliermarsh