Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: add more test coverage for the incremental merkle tree #35

Closed
JordyRo1 opened this issue Jun 12, 2024 · 1 comment · Fixed by #39
Closed

dev: add more test coverage for the incremental merkle tree #35

JordyRo1 opened this issue Jun 12, 2024 · 1 comment · Fixed by #39
Assignees
@JordyRo1

Comments

@JordyRo1
Copy link
Contributor

JordyRo1 commented Jun 12, 2024 •
edited
Loading

The actual merkle tree hook contract
(cf: https://github.com/astraly-labs/hyperlane_starknet/blob/main/contracts/src/contracts/hooks/merkle_tree_hook.cairo) lacks testing for the internal functions. The idea is to try every single function to avoid unexpected outputs.
@JordyRo1 JordyRo1 self-assigned this Jun 12, 2024
@EvolveArt EvolveArt moved this to Todo in Pragma Backlog Jun 13, 2024
@EvolveArt EvolveArt changed the title Dev: Add more test coverage for the incremental merkle tree dev: Add more test coverage for the incremental merkle tree Jun 13, 2024
@EvolveArt EvolveArt changed the title dev: Add more test coverage for the incremental merkle tree dev: add more test coverage for the incremental merkle tree Jun 13, 2024
@EvolveArt EvolveArt moved this from Todo to In Progress in Pragma Backlog Jun 13, 2024
@EvolveArt
Copy link
Contributor

related issue #37

@JordyRo1 JordyRo1 mentioned this issue Jun 17, 2024
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Pragma Backlog Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JordyRo1 JordyRo1

Labels
None yet
Projects
Pragma Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Test coverage for merkle related functions and keccak bug fix astraly-labs/hyperlane_starknet
2 participants
@EvolveArt @JordyRo1