Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference in fitting results compared to fortran sedfitter #62

Open
mattpovich opened this issue Jul 24, 2018 · 2 comments
Open

Difference in fitting results compared to fortran sedfitter #62

mattpovich opened this issue Jul 24, 2018 · 2 comments

Comments

@mattpovich
Copy link

In a test fit of Kurucz model atmospheres to a large (150,000) catalog of combined UKIDSS/2MASS and GLIMPSE point sources in a chunk of the Galactic midplane, I find ~10% more badly fit sources using the python sedfitter than previously with the fortran sedfitter. Best of my knowledge* all fitting parameters are the same (extinction law is your old ex_law_gl.par file, cpd=2, minimum datapoints = 4).

*Am I correct that the format/units of old extinction law files, including lots of extraneous columns, are still appropriate for the python sedfitter?

@astrofrog
Copy link
Owner

The old extinction files should still work with the new SED fitter. There was a bug I fixed in the Python SED fitter that may have been present in the old fitter that changes the reduced chi^2 values a little. Could you try and compare the chi^2 values for the best fit before and after, and see if the agreement depends on the number of valid fluxes?

@mattpovich
Copy link
Author

mattpovich commented Jul 31, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants