Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to customise the task name when using @df #126

Closed
tatiana opened this issue Feb 21, 2022 · 0 comments
Closed

Allow users to customise the task name when using @df #126

tatiana opened this issue Feb 21, 2022 · 0 comments
Labels
good first issue Good for newcomers improvement Enhancement or improvement in an existing feature priority/medium Medium priority
Milestone
0.7.x

Comments

@tatiana
Copy link
Collaborator

tatiana commented Feb 21, 2022 •
edited
Loading

Context

As of Astro 0.5.1, if a user calls multiple times a function decorated with @df (example below), the tasks will be automatically named row_to_gcs_files__1. At the moment, the user cannot override the default task_id name when using @df.

@df
def rows_to_gcs_files()

This behavior is different from the @task decorator, which allows users to specify task_id. We should make them consistent. This works:

@task(task_id = 'load_json')

Acceptance criteria

  • Users are able to override the default task_id name when using the df decorator, similar to the @task decorator
  • Ask @mag3141592 (bug reporter) to review the PR
@tatiana tatiana added feature New feature or request good first issue Good for newcomers bug Something isn't working and removed feature New feature or request bug Something isn't working labels Feb 21, 2022
@tatiana tatiana added this to the 0.6.1 milestone Feb 21, 2022
@tatiana tatiana added the priority/medium Medium priority label Feb 21, 2022
dimberman added a commit that referenced this issue Mar 5, 2022
@dimberman
Allow users to customise the task name when using @df #126
48cc11c 
Context

As of Astro 0.5.1, if a user calls multiple times a function decorated with @df (example below), the tasks will be automatically named row_to_gcs_files__1. At the moment, the user cannot override the default task_id name when using @df.

@df
def rows_to_gcs_files()
This behavior is different from the @task decorator, which allows users to specify task_id. We should make them consistent. This works:

@task(task_id = 'load_json')
Acceptance criteria

Users are able to override the default task_id name when using the df decorator, similar to the @task decorator
Ask @mag3141592 (bug reporter) to review the PR
dimberman added a commit that referenced this issue Mar 7, 2022
@dimberman
Allow users to customise the task name when using @df #126 (#168)
7d93ce8 
* Allow users to customise the task name when using @df #126

Context

As of Astro 0.5.1, if a user calls multiple times a function decorated with @df (example below), the tasks will be automatically named row_to_gcs_files__1. At the moment, the user cannot override the default task_id name when using @df.

@df
def rows_to_gcs_files()
This behavior is different from the @task decorator, which allows users to specify task_id. We should make them consistent. This works:

@task(task_id = 'load_json')
Acceptance criteria

Users are able to override the default task_id name when using the df decorator, similar to the @task decorator
Ask @mag3141592 (bug reporter) to review the PR

* make optional

* fix hanging test
utkarsharma2 pushed a commit that referenced this issue Mar 10, 2022
@dimberman @utkarsharma2
Allow users to customise the task name when using @df #126 (#168)
ddaa5c7 
* Allow users to customise the task name when using @df #126

Context

As of Astro 0.5.1, if a user calls multiple times a function decorated with @df (example below), the tasks will be automatically named row_to_gcs_files__1. At the moment, the user cannot override the default task_id name when using @df.

@df
def rows_to_gcs_files()
This behavior is different from the @task decorator, which allows users to specify task_id. We should make them consistent. This works:

@task(task_id = 'load_json')
Acceptance criteria

Users are able to override the default task_id name when using the df decorator, similar to the @task decorator
Ask @mag3141592 (bug reporter) to review the PR

* make optional

* fix hanging test
@tatiana tatiana added improvement Enhancement or improvement in an existing feature and removed feature New feature or request labels Mar 11, 2022
utkarsharma2 pushed a commit that referenced this issue Mar 30, 2022
@dimberman @utkarsharma2
Allow users to customise the task name when using @df #126 (#168)
25ca114 
* Allow users to customise the task name when using @df #126

Context

As of Astro 0.5.1, if a user calls multiple times a function decorated with @df (example below), the tasks will be automatically named row_to_gcs_files__1. At the moment, the user cannot override the default task_id name when using @df.

@df
def rows_to_gcs_files()
This behavior is different from the @task decorator, which allows users to specify task_id. We should make them consistent. This works:

@task(task_id = 'load_json')
Acceptance criteria

Users are able to override the default task_id name when using the df decorator, similar to the @task decorator
Ask @mag3141592 (bug reporter) to review the PR

* make optional

* fix hanging test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement Enhancement or improvement in an existing feature priority/medium Medium priority
Projects
None yet
Milestone
0.7.x
Development

No branches or pull requests
2 participants
@tatiana @dimberman