Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "include" directory to project #1560

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

feluelle
Copy link
Member

Description

What is the current behavior?

See the referenced issue for details.

closes: #1440

What is the new behavior?

After reading python-poetry/poetry#2015, it seems the best solution is to include the "include" directory directly in the project.

Does this introduce a breaking change?

No.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

After reading python-poetry/poetry#2015, it seems the best solution is to include the "include" directory directly in the project.
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 94.06% // Head: 97.59% // Increases project coverage by +3.52% 🎉

Coverage data is based on head (4e624b3) compared to base (ba25f0c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1560      +/-   ##
==========================================
+ Coverage   94.06%   97.59%   +3.52%     
==========================================
  Files          89       22      -67     
  Lines        4417      789    -3628     
  Branches      440        0     -440     
==========================================
- Hits         4155      770    -3385     
+ Misses        178       19     -159     
+ Partials       84        0      -84     
Impacted Files Coverage Δ
sql-cli/sql_cli/project.py 97.64% <100.00%> (ø)
python-sdk/src/astro/utils/load.py
python-sdk/src/astro/sql/table.py
...thon-sdk/src/astro/sql/operators/export_to_file.py
python-sdk/src/astro/constants.py
python-sdk/src/astro/files/types/ndjson.py
...dk/src/astro/databricks/load_file/load_file_job.py
python-sdk/src/astro/sql/operators/export_file.py
python-sdk/src/astro/databases/google/bigquery.py
...hon-sdk/src/astro/files/locations/google/gdrive.py
... and 58 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@feluelle feluelle merged commit 4e0dabb into main Jan 10, 2023
@feluelle feluelle deleted the feature/move-include-folder-to-project branch January 10, 2023 13:51
utkarsharma2 pushed a commit that referenced this pull request Jan 17, 2023
# Description

## What is the current behavior?

See the referenced issue for details.

closes: #1440 

## What is the new behavior?

After reading python-poetry/poetry#2015, it
seems the best solution is to include the "include" directory directly
in the project.

## Does this introduce a breaking change?

No.

### Checklist
- [x] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary
@pankajkoti pankajkoti added this to the sql-cli/0.3.0 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix where we place the sql cli include directory
3 participants