remove transform file #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimberman
changed the title
tatiana
reviewed
Mar 4, 2022
src/astro/sql/__init__.py
Outdated
| @@ -63,6 +64,10 @@ def transform_file( | |||
| warehouse: Optional[str] = None, | |||
| output_table: Table = None, | |||
| ): | |||
| warnings.warn( | |||
| "astro.sql.transform_file is now deprecated and will be taken out in version 1.0. Please use astro.sql.render instead" | |||
| ) | |||
There was a problem hiding this comment.
@dimberman since we are in an alpha version, and we have a disclaimer saying that the interface can change, wouldn't it make sense to just remove this feature now - as opposed to wait a stable release? This seems a less disruptive change than changing how we do query templating - and for that change we did not wait release 1.0.x
There was a problem hiding this comment.
@tatiana fair enough, I'll just remove it
dimberman
changed the title
dimberman
force-pushed
the
deprecate-transform-file
branch
from
523be8b
to
05ad1bd
Compare
utkarsharma2
pushed a commit
that referenced
this pull request
Mar 10, 2022
* added warning of deprecation of transform file * remove function instead of deprecating it
utkarsharma2
pushed a commit
that referenced
this pull request
Mar 30, 2022
* added warning of deprecation of transform file * remove function instead of deprecating it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have aql.render, the transform_file function is redundant and should be removed as part of 1.0