Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added absolute path as base dir for benchmarking script because relat… #461

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

utkarsharma2
Copy link
Collaborator

Partially Closes: #460

Airflow 2.2.5+ expects an absolute path for the $AIRFLOW_HOME env variable, updated the script to pass the absolute path.

Fix error -
Cannot use relative path: sqlite:///./unittests.db to connect to sqlite. Please use absolute path such as sqlite:////tmp/airflow.db.

…ive path was not compatible with airflow <=2.2.5.
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #461 (972c4da) into main (e9dc2f7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   90.97%   90.97%           
=======================================
  Files          41       41           
  Lines        1319     1319           
  Branches      168      168           
=======================================
  Hits         1200     1200           
  Misses         99       99           
  Partials       20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9dc2f7...972c4da. Read the comment docs.

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you very much, @utkarsharma2 !

@utkarsharma2 utkarsharma2 merged commit f49f087 into main Jun 16, 2022
@utkarsharma2 utkarsharma2 deleted the fix-benchmark-for-airflow-2.2.5+ branch June 16, 2022 09:47
@kaxil
Copy link
Collaborator

kaxil commented Jun 16, 2022

The PR title/ commit message was way too long 😆 -- time to paste the link https://cbea.ms/git-commit/ 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with benchmarking script
3 participants