Change catching ValueError and AttributeError to DatabaseCustomError #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #595 +/- ##
==========================================
+ Coverage 92.80% 93.26% +0.45%
==========================================
Files 41 41
Lines 1655 1663 +8
Branches 210 211 +1
==========================================
+ Hits 1536 1551 +15
+ Misses 93 89 -4
+ Partials 26 23 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
utkarsharma2
reviewed
Aug 1, 2022
utkarsharma2
reviewed
Aug 1, 2022
utkarsharma2
reviewed
Aug 1, 2022
utkarsharma2
reviewed
Aug 1, 2022
sunank200
force-pushed
the
catch-errors-at-line
branch
from
5d17ca3
to
9590976
Compare
sunank200
requested review from
utkarsharma2,
tatiana,
dimberman,
kaxil,
pankajastro and
pankajkoti
utkarsharma2
approved these changes
Aug 4, 2022
utkarsharma2
pushed a commit
that referenced
this pull request
Aug 8, 2022
…595) * Change catching ValueError and AttributeError to DatabaseCustomError * Add test for DatabaseCustomError * Raise and show exception message
kaxil
pushed a commit
that referenced
this pull request
Aug 18, 2022
…595) * Change catching ValueError and AttributeError to DatabaseCustomError * Add test for DatabaseCustomError * Raise and show exception message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
Currently in Snowflake load_file, ValueError and AttributeError are being catched at function level but it should be caught at the line and thrown that error.
closes: #583
What is the new behavior?
DatabaseCustomErrorto raise generic errors like ValueError and AttributeErrorDoes this introduce a breaking change?
No
Checklist