-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue reported by the community in slack with lineage in Cosmos 1.1 #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #526 +/- ##
=======================================
Coverage 92.37% 92.37%
=======================================
Files 49 49
Lines 1927 1941 +14
=======================================
+ Hits 1780 1793 +13
- Misses 147 148 +1
☔ View full report in Codecov by Sentry. |
tatiana
force-pushed
the
community-issue
branch
from
September 12, 2023 09:34
9e15f87
to
101c2e5
Compare
tatiana
force-pushed
the
community-issue
branch
from
September 12, 2023 09:37
b1bd6f5
to
93defee
Compare
mobuchowski
approved these changes
Sep 12, 2023
harels
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @tatiana
tatiana
added a commit
that referenced
this pull request
Sep 14, 2023
Bug fixes * Fix attempt of emitting OpenLineage events if task execution fails by @tatiana in #526 * Fix Rust dependency for Windows users by @tatiana in #526 * Fix DbtRunOperationLocalOperator missing flags by @tatiana in #529 * Fix DbtRunLocalOperator to support the full refresh argument by @tatiana in #529 * Remove redundant prefix of task names when test_behavior = TestBehavior.AFTER_EACH by @binhnq94 in #524 * Fix rendering vars in `DbtModel` when using `LoadMode.CUSTOM` by @dojinkimm in #502 Others * Docs: add `documentation comparing Airflow and dbt concepts <https://astronomer.github.io/astronomer-cosmos/getting_started/dbt-airflow-concepts.html>`_ by @tatiana in #523. * Update PyPI project links by @tatiana in #528 * pre-commit updates
tatiana
added a commit
that referenced
this pull request
Sep 14, 2023
Bug fixes * Fix attempt of emitting OpenLineage events if task execution fails by @tatiana in #526 * Fix Rust dependency for Windows users by @tatiana in #526 * Fix DbtRunOperationLocalOperator missing flags by @tatiana in #529 * Fix DbtRunLocalOperator to support the full refresh argument by @tatiana in #529 * Remove redundant prefix of task names when test_behavior = TestBehavior.AFTER_EACH by @binhnq94 in #524 * Fix rendering vars in `DbtModel` when using `LoadMode.CUSTOM` by @dojinkimm in #502 Others * Docs: add `documentation comparing Airflow and dbt concepts <https://astronomer.github.io/astronomer-cosmos/getting_started/dbt-airflow-concepts.html>`_ by @tatiana in #523. * Update PyPI project links by @tatiana in #528 * pre-commit updates
Merged
harels
pushed a commit
that referenced
this pull request
Sep 14, 2023
Bug fixes * Remove redundant prefix of task names when test_behavior = TestBehavior.AFTER_EACH by @binhnq94 in #524 * Fix rendering vars in `DbtModel` when using `LoadMode.CUSTOM` by @dojinkimm in #502 * Fix attempt of emitting OpenLineage events if task execution fails by @tatiana in #526 * Fix Rust dependency for Windows users by @tatiana in #526 * Fix DbtRunOperationLocalOperator missing flags by @tatiana in #529 * Fix DbtRunLocalOperator to support the full refresh argument by @tatiana in #529 Others * Docs: add `documentation comparing Airflow and dbt concepts <https://astronomer.github.io/astronomer-cosmos/getting_started/dbt-airflow-concepts.html>`_ by @tatiana in #523. * Update PyPI project links by @tatiana in #528 * pre-commit updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following issue, that was reported in slack by a user named Sai:
"After upgrading to cosmos 1.1, I see the below error in Airflow logs. I don't have any OpenLineage integrations. Is there a way to stop emitting this error?"
The issue was reported to happen using:
Since the issue was reported, I learned that
get_openlineage_facets_on_complete
is called even ifexecute
fails becauseget_openlineage_facets_on_failure
is not currently implemented.Closes: #530 (Rust dependency issue reported)