Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Airflow Datasets #171

Merged
merged 5 commits into from
Jul 20, 2023

Conversation

cicerojmm
Copy link
Contributor

Implementation of Airflow Datasets (data-aware scheduling) functionality that became available from version 2.4.0.

In this implementation it is possible to build Datasets in two ways:

  • The first is directly referencing the URI of the dataset in the appropriate parameters of both the producing tasks (outlets) and the consuming DAGs (schedule)
  • the second is to have a specific YAML file to declare datasets (URI and Names) and thus reference this file indicating only the names of the datasets to be used by the producing tasks and consuming DAGs, as the URI will be selected automatically.

Referencied Issue: #151

@ericbuzato
Copy link

This feature is going to be really cool, I can't wait to use it in my pipelines! ☝️

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: -4.02 ⚠️

Comparison is base (7d2782b) 83.61% compared to head (da8d3b9) 79.60%.

❗ Current head da8d3b9 differs from pull request most recent head f169dab. Consider uploading reports for the commit f169dab to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   83.61%   79.60%   -4.02%     
==========================================
  Files           6        6              
  Lines         525      559      +34     
==========================================
+ Hits          439      445       +6     
- Misses         86      114      +28     
Impacted Files Coverage Δ
dagfactory/utils.py 87.06% <15.38%> (-9.05%) ⬇️
dagfactory/dagbuilder.py 73.13% <22.72%> (-3.35%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ciceromoura
Copy link

@ajbosco
I added tests to increase coverage, I believe now the merge will pass

@ajbosco
Copy link
Contributor

ajbosco commented Jul 20, 2023

Thanks!

@ajbosco ajbosco merged commit 78ed3d8 into astronomer:master Jul 20, 2023
4 checks passed
@karguru-aws
Copy link

Does the code factory support AWS Operators like Glue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants