Cast callbacks to functions when set with default_args on task groups #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Cast task group callbacks into funcs
Removing print debug
fix error message at test_build_task_groups_with_callbacks
fix TaskGroup object indentation
|
Hey @Baraldo, Thank you for the PR. Could you please rebase and fix the merge conflict? |
|
closing this favour of #235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
When used in the task group's default_args, callbacks are passed as strings to the tasks, which ends up generating failures.
The idea is to perform the same parse used in
make_task(it is necessary to check whether the default_args attribute is defined, since it is optional and defaults to None) and perhaps in the future modularize this conversion functionality in order to cover the widespread use of default_args.