Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message_max_bytes producer option #62

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

lpsinger
Copy link
Contributor

@lpsinger lpsinger commented Oct 6, 2022

No description provided.

@cnweaver cnweaver merged commit 4a4253f into astronomy-commons:master Oct 7, 2022
@lpsinger lpsinger deleted the message-max-bytes branch October 7, 2022 13:10
lpsinger added a commit to lpsinger/userguide that referenced this pull request Oct 7, 2022
Kafka has a default max message size of 1 MB. The base64-encoded
sky maps are just barely too large to fit. Enabling Zstandard
compression brings the message size below Kafka's broker-side
default limits. However, there is also a producer client-side
config called `message.max.bytes` that is applied _before_
compression.

GCN will require the producer to set the following two client-side
configs:

```
compression.type = zstd
message.max.bytes = 1024 * 1024 * 2
```

These options should be coming in the next release of adc-streaming
with the following PRs:

* astronomy-commons/adc-streaming#61
* astronomy-commons/adc-streaming#62

Until then, we can set the configs manually by monkeypatching the
`adc.producer.ProducerConfig` class.

Fixes #459.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants