Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better mypy hints #316

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Better mypy hints #316

merged 1 commit into from
Jul 26, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Downstream packages that use mypy type checking are unhappy with the loss of type hints in the un-wrapped write_parquet_metadata method.

@delucchi-cmu delucchi-cmu requested a review from camposandro July 26, 2024 20:31
@delucchi-cmu delucchi-cmu merged commit 8db1893 into main Jul 26, 2024
10 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/mypy branch July 26, 2024 20:36
Copy link

Before [3234fcf] After [9a74b4c] Ratio Benchmark (Parameter)
87.6±3ms 89.2±2ms 1.02 benchmarks.Suite.time_paths_creation
378±3ms 379±2ms 1 benchmarks.Suite.time_outer_pixel_alignment
969±3μs 973±4μs 1 benchmarks.time_test_cone_filter_multiple_order
78.7±0.5ms 78.1±1ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order7
78.4±0.8ms 77.6±0.3ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info
41.6±1ms 41.1±1ms 0.99 benchmarks.Suite.time_pixel_tree_creation
119±0.8ms 118±1ms 0.99 benchmarks.time_test_alignment_even_sky
13.8±0.7ms 13.2±0.2ms 0.96 benchmarks.Suite.time_inner_pixel_alignment
20.8±0.6ms 19.1±0.7ms 0.92 benchmarks.MetadataSuite.time_load_partition_info_order6

Click here to view all benchmarks.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.85%. Comparing base (3234fcf) to head (78e6ee2).
Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   93.85%   93.85%           
=======================================
  Files          58       58           
  Lines        2049     2049           
=======================================
  Hits         1923     1923           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants