-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace FilePointer with universal pathlib #336
Conversation
Click here to view all benchmarks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
==========================================
- Coverage 94.04% 93.99% -0.05%
==========================================
Files 58 58
Lines 2132 2115 -17
==========================================
- Hits 2005 1988 -17
Misses 127 127 ☔ View full report in Codecov by Sentry. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked in details, but it looks great. I have an only question, should we allow something like str | Path | UPath
for "very public" interfaces like read_from_hipscat
?
Change Description
Related to #320, #313, #307
Closes #79
Solution Description
Use fsspec's project, universal-pathlib as a path provider. In this way, everywhere we currently pass in a
FilePointer
we can use aPath
instead, and when we need to create remote connections, useUPath
.Code Quality