Improve reading/writing of fits file. #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## hats #361 +/- ##
=======================================
Coverage ? 92.80%
=======================================
Files ? 48
Lines ? 1946
Branches ? 0
=======================================
Hits ? 1806
Misses ? 140
Partials ? 0 ☔ View full report in Codecov by Sentry. |
camposandro
reviewed
Sep 30, 2024
camposandro
approved these changes
Oct 1, 2024
4 tasks
delucchi-cmu
added a commit
that referenced
this pull request
Oct 16, 2024
* Initial renaming (#352) * Initial renaming * A few more spots. * Docs issues found in code review. * Few more issues of bad find/replace... * Update unit test data with changes to hipscat-import (#354) * Update unit test data with changes to hipscat-import * Add new pylint config. * Create HIPS-style properties file (#358) * Update unit test data with changes to hipscat-import * Add new pylint config. * catalog_info.json -> properties. * Support hips-style space-delimited lists * Good type hint * Reduce duplication. * Changes from code review * Add default column to properties (#359) * Add default column to properties * Add fractional coverage on partition info * Add convenience import. * Clean it up * Comment about square degrees. * Add copy_and_update * replace hipscat index * update docs * fix typo * isort * rename test hipscat id * Improve reading/writing of fits file. (#361) * Improve reading/writing of fits file. * Pylint findings * Set total_rows to non-none value. (#362) * Code review comments. * change healpix to index type * update return type * Clean up straggling instances of hips/hipscat (#369) * Straggling instances of hips/hipscat * A little more cleanup * Insert dataset dir and use general ra/dec column names. (#377) * Insert dataset dir and use general ra/dec column names. * Update documentated directory structure. * Code review comments. --------- Co-authored-by: Sean McGuire <seanmcgu@andrew.cmu.edu> Co-authored-by: Sean McGuire <123987820+smcguire-cmu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Closes #340. Related to #355.
Re-imports unit test data. Discovered that empty list values could sneak by the
exclude_noneon pydantic's model dump, and added some further hints to avoid this.