Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken unittests #383

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Fix broken unittests #383

merged 2 commits into from
Oct 17, 2024

Conversation

jeremykubica
Copy link
Contributor

The HATS unittests were failing because of trying to compare a list with units to a threshold without units.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (ff2fa17) to head (c9ca586).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files          48       48           
  Lines        1933     1933           
=======================================
  Hits         1793     1793           
  Misses        140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 17, 2024

Before [f6d84a8] After [7535732] Ratio Benchmark (Parameter)
13.8±0.4ms 14.3±0.2ms 1.04 benchmarks.Suite.time_inner_pixel_alignment
75.1±0.6ms 75.3±0.5ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
358±3ms 359±5ms 1 benchmarks.Suite.time_outer_pixel_alignment
90.3±2ms 90.1±3ms 1 benchmarks.Suite.time_paths_creation
958±10μs 954±2μs 1 benchmarks.time_test_cone_filter_multiple_order
51.4±1ms 50.6±1ms 0.99 benchmarks.Suite.time_pixel_tree_creation
75.6±0.6ms 74.1±1ms 0.98 benchmarks.MetadataSuite.time_load_partition_join_info
129±1ms 127±0.7ms 0.98 benchmarks.time_test_alignment_even_sky
21.0±0.2ms 20.4±0.1ms 0.97 benchmarks.MetadataSuite.time_load_partition_info_order6

Click here to view all benchmarks.

@jeremykubica jeremykubica merged commit ffae445 into main Oct 17, 2024
12 checks passed
@jeremykubica jeremykubica deleted the fix_broken_unittests branch October 17, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants