Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin astropy temporarily #384

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Pin astropy temporarily #384

merged 1 commit into from
Oct 17, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Recent changes in mocpy, cdshealpix, and astropy have introduced regressions. This pins the astropy version to an earlier one, while we attempt to release hats renaming changes.

@delucchi-cmu delucchi-cmu mentioned this pull request Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (0e5b034) to head (17029fe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files          48       48           
  Lines        1933     1933           
=======================================
  Hits         1793     1793           
  Misses        140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [0e5b034] After [d17cf53] Ratio Benchmark (Parameter)
18.7±1ms 19.7±0.6ms 1.06 benchmarks.MetadataSuite.time_load_partition_info_order6
13.3±0.3ms 13.9±0.6ms 1.05 benchmarks.Suite.time_inner_pixel_alignment
375±2ms 379±2ms 1.01 benchmarks.Suite.time_outer_pixel_alignment
73.3±0.9ms 73.1±0.7ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
72.9±0.8ms 72.8±0.5ms 1 benchmarks.MetadataSuite.time_load_partition_join_info
44.7±0.9ms 44.8±1ms 1 benchmarks.Suite.time_pixel_tree_creation
123±1ms 124±0.4ms 1 benchmarks.time_test_alignment_even_sky
1.06±0.01ms 1.06±0ms 1 benchmarks.time_test_cone_filter_multiple_order
89.4±2ms 88.5±2ms 0.99 benchmarks.Suite.time_paths_creation

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit 632292a into main Oct 17, 2024
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/pin branch October 17, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants