Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenience method to estimate mindist for a given order. #392

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

delucchi-cmu
Copy link
Contributor

See astronomy-commons/lsdb#408

This kind of calculation is performed in a few different places, and may eventually be replaced by a more precise minimum distance calculation.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.00%. Comparing base (499c66a) to head (fb7683a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   92.98%   93.00%   +0.01%     
==========================================
  Files          49       49              
  Lines        1996     2001       +5     
==========================================
+ Hits         1856     1861       +5     
  Misses        140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [499c66a] After [9001adb] Ratio Benchmark (Parameter)
91.1±0.4ms 93.5±0.9ms 1.03 benchmarks.MetadataSuite.time_load_partition_info_order7
49.4±0.6ms 50.6±0.6ms 1.03 benchmarks.Suite.time_pixel_tree_creation
21.7±0.2ms 22.3±0.4ms 1.02 benchmarks.MetadataSuite.time_load_partition_info_order6
91.2±0.3ms 93.2±1ms 1.02 benchmarks.MetadataSuite.time_load_partition_join_info
13.2±0.5ms 13.4±0.4ms 1.01 benchmarks.Suite.time_inner_pixel_alignment
109±2ms 110±2ms 1.01 benchmarks.Suite.time_paths_creation
384±0.5ms 383±1ms 1 benchmarks.Suite.time_outer_pixel_alignment
125±0.5ms 126±1ms 1 benchmarks.time_test_alignment_even_sky
990±5μs 981±7μs 0.99 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit 1628457 into main Oct 23, 2024
10 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/order2mindist branch October 23, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants