Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct pixel boundaries when plotting pixels at orders lower than 3 show #413

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

smcguire-cmu
Copy link
Contributor

Previously order 0-2 healpix were split to order 3 when plotting, showing incorrect borders. This adds the ability to plot lower order pixels with more steps along the edges, and correct borders.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.99%. Comparing base (f778966) to head (1ff39ad).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
+ Coverage   92.95%   92.99%   +0.03%     
==========================================
  Files          49       49              
  Lines        2116     2127      +11     
==========================================
+ Hits         1967     1978      +11     
  Misses        149      149              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 1, 2024

Before [f778966] After [1f0b9c4] Ratio Benchmark (Parameter)
22.5±0.2ms 23.0±0.2ms 1.02 benchmarks.MetadataSuite.time_load_partition_info_order6
13.4±1ms 13.5±1ms 1.01 benchmarks.Suite.time_inner_pixel_alignment
94.0±0.4ms 93.8±0.6ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
379±1ms 377±4ms 1 benchmarks.Suite.time_outer_pixel_alignment
110±1ms 110±0.5ms 1 benchmarks.Suite.time_paths_creation
45.5±0.2ms 45.5±0.09ms 1 benchmarks.Suite.time_pixel_tree_creation
125±0.6ms 125±0.4ms 1 benchmarks.time_test_alignment_even_sky
1.01±0.03ms 1.02±0.03ms 1 benchmarks.time_test_cone_filter_multiple_order
93.4±0.4ms 92.9±0.3ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info

Click here to view all benchmarks.

Copy link
Contributor

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some comments to the unit test calculations as well?

src/hats/inspection/visualize_catalog.py Show resolved Hide resolved
@smcguire-cmu smcguire-cmu force-pushed the sean/fix-plotting-order branch from f2fc2fc to 1ff39ad Compare November 1, 2024 21:07
@smcguire-cmu smcguire-cmu merged commit 17ec4ac into main Nov 1, 2024
11 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/fix-plotting-order branch November 1, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants