Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller_acks): Add handling of heartbeat acks and timeouts #34

Merged
merged 6 commits into from
Oct 12, 2023

Conversation

donovansolms
Copy link
Collaborator

@donovansolms donovansolms commented Oct 11, 2023

This PR fixes an issue where IBC acks and timeouts were not handled by the controller and resulted in errors shown to the relayer. This did not have any impact on the functionality of the controller or satellite.

The typical error looked like

message: "failed to execute message; message index: 1: acknowledge packet callback failed: on ack: Error parsing into type ibc_controller_package::IbcProposal: unknown field `heartbeat`, expected `id` or `messages`

Note: This was tested using Terra as controller and Neutron, Injective as satellites

@donovansolms donovansolms requested a review from epanchee October 11, 2023 13:11
@epanchee
Copy link
Collaborator

epanchee commented Oct 11, 2023

Don't you mind to cover Heartbeat messages in ack and timeout tests?

Also, as we keep release version aligned with the main crate in workspace could you bump astroport-ibc to 1.2.1?

@donovansolms
Copy link
Collaborator Author

Also, as we keep release version aligned with the main crate in workspace could you bump astroport-ibc to 1.2.1?

Is this contract level version fine?

@epanchee
Copy link
Collaborator

Also, as we keep release version aligned with the main crate in workspace could you bump astroport-ibc to 1.2.1?

Is this contract level version fine?

I'd better bump it to 1.1.0 as it looks more as minor change rather than patch.

Copy link
Collaborator

@epanchee epanchee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@donovansolms donovansolms merged commit 61f3cf9 into main Oct 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants