Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization tutorial #593

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ceb8
Copy link
Member

@ceb8 ceb8 commented Mar 7, 2024

…s/setup-python-4.6.0

Bump actions/setup-python from 4.5.0 to 4.6.0

  • Check the box to confirm that you are familiar with the contributing guidelines and/or indicate (check the box) that you are familiar with our contributing workflow.
  • Confirm that any contributed tutorials contain a complete Introduction which includes an Author list, Learning Goals, Keywords, Companion Content (if applicable), and a Summary.
  • Check the box to confirm that you are familiar with the Astropy community code of conduct and you agree to follow the CoC.

This tutorial uses Gaia data to demonstrate the use of SkyCoords and their method apply_space_motion to evolve stellar position through time when the proper motion and radial velocity values are known.

…/actions/setup-python-4.6.0

Bump actions/setup-python from 4.5.0 to 4.6.0
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ceb8 ceb8 changed the title Merge pull request #582 from astropy/dependabot/github_actions/action… Visualization tutorial Mar 7, 2024
@pllim
Copy link
Member

pllim commented Aug 26, 2024

Why is the commit so weird?

@ceb8
Copy link
Member Author

ceb8 commented Aug 27, 2024

Why is the commit so weird?

I think becuase I ran the tutorial notebook checker on it to strip out the notebook output cells (it seems to make changes even if I've already saved it in an un-run state).

@pllim
Copy link
Member

pllim commented Aug 27, 2024

@ceb8 , would you mind amending the commit message so future git blame would be less confusing? Thanks! 🙏

@ceb8
Copy link
Member Author

ceb8 commented Aug 27, 2024

@pllim Given how long this notebook has sat here with no interaction I am hesitent to do anything to it unless I feel there is a reasonable chance it will actually get into the repo, but I'll keep it in mind for a pre-merge issue.

Copy link

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ceb8!

I was summoned by @pllim on Slack and gave it a quick run through; overall I think it does a good job and descriptions were easy to follow along. The only small piece I have to comment is that I think a next logical step for a user could be to try and modify the ADQL query to see what else they can do. Though the comments are great with explaining the what those keywords do, I wonder if it's better to link directly to the PDF of the ADQL spec, rather than the broader doc page? I feel like the .pdf and .doc links aren't prominent enough at the bottom such that a user who is at the level of this notebook may inevitably miss the small hyperlinks at the bottom. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants