Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hips2fits remove imshow calls from remote tests #1927

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

bmatthieu3
Copy link
Contributor

This refers #1734

@bsipocz @keflavich - I commented the call to matplotlib functions in the remote tests of hips2fits

@bsipocz
Copy link
Member

bsipocz commented Jan 12, 2021

I've rebased to

  • get rid of the astropy-helpers changes
  • pick up the CI
  • fix the docs warnings.

@bsipocz
Copy link
Member

bsipocz commented Jan 12, 2021

Except I cannot push it back to this branch. @bmatthieu3 - please enable the edit by maintainer checkbox on the right-hand side.

@bmatthieu3
Copy link
Contributor Author

@bsipocz - This checkbox does not appear for me and it seems it is because the forked astroquery repo we have lies in an organization (cds-astro) rather than in a specific user. isaacs/github#1681

I added you as a maintainer of our forked repo: https://github.com/cds-astro/astroquery
Tell me if it works after that.

@keflavich
Copy link
Contributor

This can be merged after a rebase, I think, but not til then.

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #1927 (0d83917) into main (4f58dae) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1927   +/-   ##
=======================================
  Coverage   67.04%   67.05%           
=======================================
  Files         411      411           
  Lines       27186    27182    -4     
=======================================
  Hits        18228    18228           
+ Misses       8958     8954    -4     
Impacted Files Coverage Δ
astroquery/hips2fits/core.py 74.25% <ø> (ø)
...stroquery/hips2fits/tests/test_hips2fits_remote.py 50.00% <ø> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f58dae...0d83917. Read the comment docs.

@bsipocz
Copy link
Member

bsipocz commented Apr 20, 2021

Thanks @bmatthieu3!

@bsipocz bsipocz merged commit 809fdfb into astropy:main Apr 20, 2021
@ManonMarchand ManonMarchand deleted the fix_imshow_hips2fits branch October 4, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants