Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow engineering/qa search terms #2000

Merged

Conversation

olyoberdorf
Copy link

closes #1996

If the user passes QA or engineering search terms, the constructed URL should not add the defaults of notengineering and/or NotFail.

@pep8speaks
Copy link

Hello @olyoberdorf! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 150:1: W391 blank line at end of file

@bsipocz bsipocz added the gemini label Apr 20, 2021
@bsipocz bsipocz added this to the v0.4.2 milestone Apr 20, 2021
@bsipocz
Copy link
Member

bsipocz commented Apr 20, 2021

Thanks @olyoberdorf!

@bsipocz bsipocz merged commit 4f58dae into astropy:main Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gemini: notengineering and NotFail defaults should respect explicit search terms
3 participants